This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Install GitHub.TeamFoundation.15 MEF component in all Visual Studio versions #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install the GitHub.TeamFoundation.15 MEF component in all Visual Studio versions. This is a workaround for #1810.
This was referenced Aug 6, 2018
Closed
Visual Studio 2017 shipped with Microsoft.VisualStudio.Threading 15.0. Reference a version that is compatible.
|
I think this was actually an issue with a reference to Microsoft.VisualStudio.Threading v15.0.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like c9703cd might have stopped the extension from working on some Visual Studio installations.
From the MEF log #1810 (comment), it appears the VSIX installer is attempting to install the
GitHub.TeamFoundation.14assembly on Visual Studio 2017 (and failing), but ignoring theGitHub.TeamFoundation.15assembly.What this PR does
GitHub.TeamFoundation.15assembly to install on all Visual Studio versionsThere should no change on Visual Studio 2015 which doesn't support version ranges and will attempt to install all MEF assemblies anyway.
Visual Studio 2017 should always install
GitHub.TeamFoundation.15, even if an erroneous attempt has been made to installGitHub.TeamFoundation.14.We don't know if Visual Studio 2019+ will release new
TeamFoundationassemblies. If they don't, this change will allow the extension to carry on working. If they do, we will need to create a newGitHub.TeamFoundation.16project to target them.Update: I think this was actually an issue with a reference to Microsoft.VisualStudio.Threading v15.0
Fixes #1810