Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fixing Checks GraphQL query on GitHub Enterprise #2122

Merged
merged 7 commits into from
Dec 12, 2018
Merged

Fixing Checks GraphQL query on GitHub Enterprise #2122

merged 7 commits into from
Dec 12, 2018

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 11, 2018 •
edited
Loading

Fixes #2117

  • Adding the appropriate null checks in GraphQL against GitHub Enterprise
  • Hiding the Checks display in the event that there are no Checks to display

grokys
grokys reviewed Dec 11, 2018
View reviewed changes
Copy link
Contributor

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding a HasChecks property you can use the CountToVisibilityConverter.

@StanleyGoldman StanleyGoldman merged commit a4d7eb5 into master Dec 12, 2018
@StanleyGoldman StanleyGoldman deleted the fix-checks-enterprise-nulls branch December 12, 2018 14:01
@MilosAuder
Copy link

Thank you for fixing this :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grokys grokys grokys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StanleyGoldman @MilosAuder @grokys @jcansdale