-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Hide resolved comments in changes tree; Indicate resolved comments on margin #2253
Hide resolved comments in changes tree; Indicate resolved comments on margin #2253
Conversation
Use pullRequest/reviewThreads instead of pullRequest/review/comments.
…thread-resolved-status
Only use reviewThreads/isResolved on github.com where they are guaranteed to be available.
e2c2462
to
8e4a5a9
Compare
Show, "This conversation was marked as resolved" on peek view when conversation has been marked as resolved.
91b62a2
to
a489f5d
Compare
I went and did A Thing replacing the info icon with the one built into visual studio. The result is a look and feel closer to a native infobar: At first I was concerned about how much it popped out in the Dark Theme even though I was using the background color that we get from Visual Studio. However, I think it's okay for the following reasons:
We've diverged a bit from what I've prototyped but I think that's fine given that my prototype relied heavily on the interaction of collapsing resolved comments. |
I think this is a good call. 👍 We're trying to communicate that someone stuck a fork in this comment thread, you're probably done. Making this pop out is a good thing! |
Previously pull request comments would be implicitly resolved when when the text near to the comment was changed. GitHub now supports comments being explicitly resolved by a user and comments becoming implicitly outdated when the text near to the comment is changed.
This pull request surfaces the
IsResolved
status of a review comment threads and hides resolved comments from the changes tree (in a similar way to how outdated comments are hidden). This makes it easy to find comments that still need to be addressed when responding to a pull request review.What this PR does
pullRequest/reviewThreads
to populate theIsResolved
status of a pull request comment threadsreviewThreads
might not be available)To do
What this PR doesn't do
How to test
https://github.com/grokys/PullRequestSandbox
in Visual StudioGitHub
paneProgram.cs
💬 1
commentProgram.cs
appears in diff view and comment is visibleThe conversation was marked as resolved
banner appears above commentNotes
Here is what is looks like in the
Dark
themeRelated #2245