This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fixing validation display on Create Repository dialog #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcansdale
reviewed
Apr 5, 2019
| @@ -107,17 +107,21 @@ | |||
| Grid.Column="1" | |||
| MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}" | |||
| Text="{Binding RepositoryName, UpdateSourceTrigger=PropertyChanged}" | |||
| SpellCheck.IsEnabled="True" | |||
There was a problem hiding this comment.
It looks like spell checking has been disabled. Was this by design?
There was a problem hiding this comment.
Yea, I disabled it, when I couldn't type VisualStudio without it calling that an error, I decided that it was not useful...
There was a problem hiding this comment.
Lol, makes sense. Though I'm perfectly capable of misspelling the name of my repo. 😉
There was a problem hiding this comment.
It look like dotcom also has spell checking disabled fro this field.
|
Added screenshots |
jcansdale
approved these changes
Apr 5, 2019
StanleyGoldman
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #2264
Depends on: