Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Change GitHub.TeamFoundation.16 version of TeamExplorerServices #2515

Merged
merged 3 commits into from
May 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2020

Change GitHub.TeamFoundation.16 version of TeamExplorerServices to use IGitActionsExt2.InitializeOrPushRepositoryToGitService().

This allows the GitHub Extension to take advantage of the Create Repository dialog available in the new Git experience in Visual Studio 16.6.

…e IGitActionsExt2.InitializeOrPushRepositoryToGitService()
@ghost ghost requested a review from jcansdale May 19, 2020 19:57
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the question about running on pre-Git experience versions of VS 2019.

@ghost
Copy link
Author

ghost commented May 21, 2020

For what it's worth, I just verified that this works as expected in the latest preview version of Visual Studio 16.

Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM!

@jcansdale jcansdale merged commit c56f7f2 into master May 22, 2020
@ghost ghost deleted the useCreateRepositoryDialog branch June 2, 2020 21:14
@yannduran
Copy link

@jcansdale

Before I update to this version, what will happen for those who choose to NOT use the so-called new Git experience? I for one find it incomplete and impossible to even consider using so far.

@ghost
Copy link
Author

ghost commented Jun 24, 2020

If you choose not to use the new Git experience, the GitHub Visual Studio extension will direct you to Team Explorer's Sync page, just like it used to.

@yannduran
Copy link

@daschult Excellent, thank you!

@ghost
Copy link
Author

ghost commented Jun 30, 2020

@yannduran Also, I should've asked before, but what features do you find incomplete in the new Git experience? We certainly have our own list of features that we're working on, but if you could provide your own list of missing features that make the new Git experience unusable, then that would help us to prioritize. 😄 Thanks!

@yannduran
Copy link

@daschult I find it incomplete compared to Team Explorer. Although Team Explorer could benefit from some improvements, many experienced developers, myself included, like the way it works on the whole.

I've only tried the new Git Experience a couple of times, because it was so hard to get anything done that I immediately had to switch back to using Team Explorer. Some features were even removed from Team Explorer which really annoyed me. The features in Team Explorer should not have been removed or changed in any way.

How are we expected to test your new window out when switching over to it means that we're expected to have to hunt all over Visual Studio to find "other ways" to do basic things that were all together in Team Explorer. Why does it always have to be so binary, one or the other? It would have been far easier if you just made the new window available, without crippling Team Explorer, and see how developers either used it or didn't use it.

I actually hope that Team Explorer will remain as an option and not be replaced by something that is dumbed down and makes us less productive. The recent trend of replacing features that just work with new "prettier" but less productive "new experiences" is annoying and completely flawed.

I guess I'm just getting sick of these "new experiences" being forced on us when they actually make professional developers less productive. Visual Studio is slowly being crippled by them (an unmodifiable new Start Window, a new search-based New Project dialog. and now the new "Git window").

@github github deleted a comment from Bible-Tech Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants