Java: Add support for additional nodes, read steps, and store steps for QL models and model ThreadLocal.initialValue #14297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
atorralba
approved these changes
Sep 26, 2023
atorralba
reviewed
Sep 26, 2023
| @@ -133,6 +135,8 @@ module Public { | |||
| result = this.(CaptureNode).getTypeImpl() | |||
| or | |||
| result = this.(FieldValueNode).getField().getType() | |||
| or | |||
| result instanceof TypeObject and this instanceof AdditionalNode | |||
There was a problem hiding this comment.
I guess instanceof TypeObject is the most restrictive assumption we can make about result in this case, right?
There was a problem hiding this comment.
Yes. I was thinking about whether the additional-node extension point ought to include some option to set the type, but that's probably just an unnecessary complication, since type strengthening will pick up a stronger type quickly from the surrounding nodes.
Yeah, as I noted above, I ended up not using those, but felt that they were nice to have anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14268 I temporarily removed an additional step in a flow configuration for
ThreadLocal.initialValue. This PR adds the step as a general purpose step applicable for all flow configurations. In order to do so we need support for adding additional store steps, so I added that capability along with read steps for symmetry. We also need an additional data flow node as an intermediate stepping stone between the store step and the jump step, so I added support for adding additional data flow nodes as well in the first commit. In the end I decided I might as well just use the existing node for the instance parameter, as that has the proper type, but I think we might as well keep the option of adding data flow nodes for any future use-cases.With these new extension points, it should be easier to add precise field-based QL models for the cases that fall outside the capabilities of MaD.