Skip to content

C++: Update QLDoc on GuardCondition #16892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

C++: Update QLDoc on GuardCondition #16892

merged 2 commits into from
Jul 3, 2024

Conversation

MathiasVP
Copy link
Contributor

This was causing some confusion here.

Support for switch statements was added in #15941.

@MathiasVP MathiasVP requested a review from a team as a code owner July 2, 2024 19:23
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Jul 2, 2024
@github-actions github-actions bot added the C++ label Jul 2, 2024
@MathiasVP MathiasVP changed the title C++: Update QLDoc on 'GuardCondition' C++: Update QLDoc on GuardCondition Jul 3, 2024
geoffw0
geoffw0 previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is the comment on class IRGuardCondition "This includes operands of logical operators but not switch statements" inaccurate as well???

@MathiasVP
Copy link
Contributor Author

MathiasVP commented Jul 3, 2024 •
edited
Loading

Is the comment on class IRGuardCondition "This includes operands of logical operators but not switch statements" inaccurate as well???

Oh! Yes, it is!

GuardCondition is simply a thin wrapper around IRGuardCondition so pretty much anything that applies to GuardCondition also applies to IRGuardCondition (and vice versa)

@MathiasVP
Copy link
Contributor Author

Fixed in 284007d. Do you mind re-approving @geoffw0?

geoffw0
geoffw0 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. 👍

@MathiasVP MathiasVP merged commit 640c842 into github:main Jul 3, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @geoffw0