Skip to content

JS: Modeling of ShellJS functions #19422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2025
Merged

JS: Modeling of ShellJS functions #19422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f6fae7a
Added test cases for `cmd`, `which` and `asyncExec`
Napalys Apr 30, 2025
25d04f1
Added support for `shelljs.which`
Napalys Apr 30, 2025
18cea2d
Added support for `shelljs.cmd` and `async-shelljs.asyncExec`
Napalys Apr 30, 2025
40d176a
Added model for shelljs.env
Napalys Apr 30, 2025
602500e
Added change note
Napalys Apr 30, 2025
33d8ffa
Added test cases for shelljs.env
Napalys May 1, 2025
d4b5ef6
Refactor process.env handling in CleartextLogging and IndirectCommand…
Napalys May 1, 2025
871e93d
Update javascript/ql/lib/semmle/javascript/frameworks/ShellJS.qll
Napalys May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added support for shelljs.which
  • Loading branch information
@Napalys
Napalys committed Apr 30, 2025
commit 25d04f1cdd11e5bf6372924363035ac2cdb4895a
9 changes: 6 additions & 3 deletions javascript/ql/lib/semmle/javascript/frameworks/ShellJS.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ module ShellJS {
shellJSMember()
.getMember([
"exec", "cd", "cp", "touch", "chmod", "pushd", "find", "ls", "ln", "mkdir", "mv",
"rm", "cat", "head", "sort", "tail", "uniq", "grep", "sed", "to", "toEnd", "echo"
"rm", "cat", "head", "sort", "tail", "uniq", "grep", "sed", "to", "toEnd", "echo",
"which",
])
.getReturn()
}
Expand Down Expand Up @@ -99,7 +100,8 @@ module ShellJS {
*/
private class ShellJSGenericFileAccess extends FileSystemAccess, ShellJSCall {
ShellJSGenericFileAccess() {
name = ["cd", "cp", "touch", "chmod", "pushd", "find", "ls", "ln", "mkdir", "mv", "rm"]
name =
["cd", "cp", "touch", "chmod", "pushd", "find", "ls", "ln", "mkdir", "mv", "rm", "which"]
}

override DataFlow::Node getAPathArgument() { result = this.getAnArgument() }
Expand All @@ -111,7 +113,8 @@ module ShellJS {
private class ShellJSFilenameSource extends FileNameSource, ShellJSCall {
ShellJSFilenameSource() {
name = "find" or
name = "ls"
name = "ls" or
name = "which"
}
}

Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/test/library-tests/frameworks/Shelljs/ShellJS.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ test_FileSystemAccess
| tst.js:60:1:60:17 | shelljs.cat(file) |
| tst.js:60:1:60:41 | shelljs ... cement) |
| tst.js:61:1:61:17 | shelljs.cat(file) |
| tst.js:65:1:65:19 | shelljs.which(file) |
test_MissingFileSystemAccess
| tst.js:65:15:65:18 | file |
test_SystemCommandExecution
| tst.js:14:1:14:27 | shelljs ... ts, cb) |
| tst.js:60:1:60:51 | shelljs ... ec(cmd) |
Expand All @@ -67,3 +67,4 @@ test_FileNameSource
| tst.js:25:1:25:22 | shelljs ... , file) |
| tst.js:26:1:26:30 | shelljs ... file2) |
| tst.js:27:1:27:24 | shelljs ... file2) |
| tst.js:65:1:65:19 | shelljs.which(file) |