Skip to content

Use github.Ptr instead of smithy-go/ptr #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Conversation

ohkinozomu
Copy link
Contributor

Currently aws/smithy-go is imported for ptr functionality only.
google/go-github Ptr can be used to reduce dependencies.

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 09:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • go.mod: Language not supported
  • third-party/github.com/aws/smithy-go/ptr/LICENSE: Language not supported
  • third-party/github.com/aws/smithy-go/ptr/NOTICE: Language not supported

Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juruen juruen merged commit e4c2f58 into github:main Apr 7, 2025
9 checks passed
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants