feat: enterprise host support #28
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds rudimentary enterprise support by introducing a new "gh-host" parameter, allowing the GitHub MCP server to direct API calls to GitHub Enterprise endpoints.
- Added the "gh-host" persistent flag.
- Bound "gh-host" to viper.
- Updated the GitHub client to use enterprise-specific base and upload URLs when provided.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
SamMorrowDrums
force-pushed
the
enterprise
branch
from
cf5ee86 to
4dc12f1
Compare
SamMorrowDrums
changed the title
|
Awesome! Do think it would make sense to support an env var (in addition to or instead of the flag)? Just because we're using them elsewhere. |
cmd/github-mcp-server/main.go
Outdated
| if host := viper.GetString("gh-host"); host != "" { | ||
| parsedURL, err := url.Parse(fmt.Sprintf("https://api.%s/", host)) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse provided GitHub host URL: %w", err) | ||
| } | ||
|
|
||
| uploadURL, err := url.Parse(fmt.Sprintf("https://uploads.%s/", host)) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse provided GitHub host URL: %w", err) | ||
| } | ||
|
|
||
| ghClient.BaseURL = parsedURL | ||
| ghClient.UploadURL = uploadURL | ||
| } |
There was a problem hiding this comment.
Maybe we can use the WithEnterpriseURLs() function in the gogithub.Client instead?
Yeah, that's easy. I was considering doing so too. Just didn't 😅 |
SamMorrowDrums
force-pushed
the
enterprise
branch
from
4dc12f1 to
953ae08
Compare
Adds support for a
gh-hostparam so that enterprises work. Tested it out with failing attempt to call localhost:go run cmd/github-mcp-server/main.go stdio --gh-host github.localhostSo the override is working well.