feat: read-only flag #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a read-only flag that restricts write operations within the GitHub MCP server to help prevent unauthorized modifications.
- Added a new persistent flag "read-only" and bound it via viper in cmd/github-mcp-server/main.go.
- Updated the runStdioServer function signature and its invocation to include the readOnly parameter.
- Modified the NewServer function in pkg/github/server.go to conditionally add write tools based on the readOnly flag.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/github-mcp-server/main.go | Added a "read-only" flag and updated function calls to pass the flag value. |
| pkg/github/server.go | Updated the NewServer function to gate write operations using the readOnly flag. |
Comments suppressed due to low confidence (1)
pkg/github/server.go:37
- The new condition controlling the addition of write-related tools for GitHub operations is introduced here without associated tests.
if !readOnly {
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
SamMorrowDrums
force-pushed
the
read-only
branch
from
f1f74f1 to
9b69085
Compare
SamMorrowDrums
force-pushed
the
read-only
branch
from
9b69085 to
76766b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a read-only flag and gate endpoints that would otherwise write behind it, so that people can avoid the risk that an LLM can write to their GitHub account entirely.