fix: use anyOf instead of nullable type array #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windsurf is erroring on the `create_pull_request` tool because we're using an array of types to make fields nullable. This PR uses `anyOf` instead and should fix the issue.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an error with the pull request creation tool by updating the JSON schema definitions for nullable types to use the "anyOf" pattern instead of an array of types.
- Changes include modifying the fields "position", "line", "side", "start_line", and "start_side" to use the new "anyOf" syntax.
- The update aims to resolve errors with Windsurf related to handling nullable types.
SamMorrowDrums
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windsurf is erroring on the
create_pull_requesttool because we're using an array of types to make fields nullable. This PR usesanyOfinstead and should fix the issue.Closes: #318