Use a config filename that is different from the binary name #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing issues in the Docker container, where viper looks for a filename, without considering the extension, resulting in it trying to parse the binary itself as JSON.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with viper misinterpreting the binary as a JSON config by changing the config filename.
- Updates the config name in the viper configuration to "github-mcp-server-config".
- Changes the JSON filename in the DumpTranslationKeyMap function to "github-mcp-server-config.json".
Comments suppressed due to low confidence (2)
pkg/translations/translations.go:27
- [nitpick] Consider defining a constant for the config name to avoid duplicating literal strings across the codebase.
v.SetConfigName("github-mcp-server-config")
pkg/translations/translations.go:64
- [nitpick] Consider using a constant for the config filename to maintain consistency and ease future changes.
file, err := os.Create("github-mcp-server-config.json")
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
SamMorrowDrums
approved these changes
Mar 28, 2025
juruen
approved these changes
Mar 28, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
This was causing issues in the Docker container, where viper looks for a filename, without considering the extension, resulting in it trying to parse the binary itself as JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was causing issues in the Docker container, where viper looks for a filename, without considering the extension, resulting in it trying to parse the binary itself as JSON:
There are probably more robust options out there, like looking in config dirs (XDG, if this was ever user installed) but this is the simplest path to fix the error.