Skip to content

chore: update deps #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

chore: update deps #76

merged 1 commit into from
Apr 3, 2025

Conversation

SamMorrowDrums
Copy link
Collaborator

@SamMorrowDrums SamMorrowDrums commented Apr 3, 2025

Update go deps and corresponding licences.

Changed one dep due to deprecation:

cmd/mcpcurl/main.go:15:2: SA1019: "golang.org/x/exp/rand" is deprecated: use the math/rand/v2 package instead. This package is scheduled to be tagged and deleted, per https://go.dev/issue/61716. (staticcheck)
"golang.org/x/exp/rand"

@Copilot Copilot AI review requested due to automatic review settings April 3, 2025 12:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates and streamlines our third‐party dependencies by removing several vendored files from the HashiCorp HCL package and updating license entries to reflect new dependency versions. Key changes include:

  • Removal of various HCL source files and associated tests.
  • Updates to dependency versions and corresponding license references in third-party-licenses.md.
  • Removal of ancillary files such as README.md and ISSUE_TEMPLATE.md.

Reviewed Changes

Copilot reviewed 197 out of 206 changed files in this pull request and generated no comments.

Show a summary per file
File Description
third-party/github.com/hashicorp/hcl/hcl/fmtcmd/fmtcmd.go Entire file removed – verify no build dependencies rely on this.
third-party/github.com/hashicorp/hcl/hcl/ast/walk.go Entire file removed – confirm that AST walking functionality is not affected.
third-party/github.com/hashicorp/hcl/hcl/ast/ast_test.go Test file removed – ensure that test coverage for AST functionality is maintained elsewhere.
third-party/github.com/hashicorp/hcl/hcl/ast/ast.go Core AST file removed – check that updated dependencies provide the necessary AST support.
third-party/github.com/hashicorp/hcl/hcl.go Main HCL file removed – confirm that downstream usage isn’t inadvertently broken.
third-party-licenses.md Multiple license entries updated to new dependency versions – ensure consistency and compliance.
third-party/github.com/hashicorp/hcl/README.md and .github/ISSUE_TEMPLATE.md Ancillary documentation files removed – verify that documentation is maintained in alternate locations if needed.
Files not reviewed (9)
  • go.mod: Language not supported
  • third-party/github.com/hashicorp/hcl/.gitignore: Language not supported
  • third-party/github.com/hashicorp/hcl/.travis.yml: Language not supported
  • third-party/github.com/hashicorp/hcl/LICENSE: Language not supported
  • third-party/github.com/hashicorp/hcl/Makefile: Language not supported
  • third-party/github.com/hashicorp/hcl/appveyor.yml: Language not supported
  • third-party/github.com/hashicorp/hcl/go.mod: Language not supported
  • third-party/github.com/hashicorp/hcl/hcl/fmtcmd/test-fixtures/.hidden.ignore: Language not supported
  • third-party/github.com/hashicorp/hcl/hcl/fmtcmd/test-fixtures/file.ignore: Language not supported
Comments suppressed due to low confidence (7)

third-party/github.com/hashicorp/hcl/hcl/fmtcmd/fmtcmd.go:1

  • The removal of fmtcmd.go could break references or build dependencies; please verify that its functionality is no longer required.
-// Derivative work from:

third-party/github.com/hashicorp/hcl/hcl/ast/walk.go:1

  • Removing walk.go may affect AST traversal capabilities; ensure that any dependent components are updated accordingly.
-package ast

third-party/github.com/hashicorp/hcl/hcl/ast/ast_test.go:1

  • The removal of ast_test.go reduces test coverage for HCL AST functionality; please confirm that tests exist elsewhere to cover these areas.
-package ast

third-party/github.com/hashicorp/hcl/hcl/ast/ast.go:1

  • The removal of ast.go, a core file defining the HCL AST, could impact parsing functionality; verify that the updated dependency supplies full AST support.
-// Package ast declares the types used to represent syntax trees for HCL

third-party/github.com/hashicorp/hcl/hcl.go:1

  • The removal of the top-level hcl.go file might affect downstream usage; please confirm that the new dependency structure meets all functional requirements.
-// Package hcl decodes HCL into usable Go structures.

third-party-licenses.md:11

  • Updated dependency versions (e.g., fsnotify from v1.7.0 to v1.8.0) need to be checked for consistency across the project; ensure all version updates are intentional and compliant.
+ - [github.com/fsnotify/fsnotify](https://pkg.go.dev/github.com/fsnotify/fsnotify) ([BSD-3-Clause](https://github.com/fsnotify/fsnotify/blob/v1.8.0/LICENSE))

third-party-licenses.md:21

  • Multiple dependency version updates are present; please verify that all new license references (including for mapstructure, cast, and others) are correct and integrated consistently.
+ - [github.com/sourcegraph/conc](https://pkg.go.dev/github.com/sourcegraph/conc) ([MIT](https://github.com/sourcegraph/conc/blob/v0.3.0/LICENSE))

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@SamMorrowDrums SamMorrowDrums merged commit 559b3ff into main Apr 3, 2025
16 checks passed
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants