chore: support x-platform licence generation #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds cross-platform license generation support by introducing separate dependency listings for Windows and Linux builds.
- Added a new license listing file for the Windows platform.
- Added a new license listing file for the Linux platform.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| third-party-licenses.windows.md | Adds dependency license details specific to Windows. |
| third-party-licenses.linux.md | Adds dependency license details specific to Linux. |
Files not reviewed (3)
- script/licenses: Language not supported
- third-party/github.com/inconshreveable/mousetrap/LICENSE: Language not supported
- third-party/golang.org/x/sys/windows/LICENSE: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
SamMorrowDrums
force-pushed
the
cross-platform-licences
branch
from
005fbdd to
17b20f2
Compare
| trap "rm -fr ${TEMPDIR}" EXIT | ||
|
|
||
| for goos in linux darwin windows ; do | ||
| GOOS="${goos}" go-licenses save ./... --save_path="${TEMPDIR}/${goos}" --force || echo "Ignore warnings" |
There was a problem hiding this comment.
That's nice you can just use GOOS
SamMorrowDrums
force-pushed
the
cross-platform-licences
branch
from
ad6fb1d to
13ecc85
Compare
SamMorrowDrums
force-pushed
the
cross-platform-licences
branch
from
13ecc85 to
9ddb049
Compare
williammartin
approved these changes
Apr 4, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #93
Generate licences/attribution for all platforms we build for.