Skip to content

feat: consider GH_ENTERPRISE_URL env in markdown author URL #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

feat: consider GH_ENTERPRISE_URL env in markdown author URL #516

merged 2 commits into from
May 7, 2025

Conversation

jonasbreuer
Copy link
Contributor

@jonasbreuer jonasbreuer commented May 6, 2025 •
edited by zkoppert
Loading

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@jonasbreuer jonasbreuer requested a review from a team as a code owner May 6, 2025 12:24
@jonasbreuer jonasbreuer mentioned this pull request May 6, 2025
Closed
@zkoppert zkoppert added enhancement New feature or request and removed enhancement New feature or request labels May 6, 2025
jmeridth
jmeridth approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you for your contribution.

@jmeridth jmeridth merged commit 0bac475 into github:main May 7, 2025
8 checks passed
@jonasbreuer jonasbreuer deleted the ghe-author-link branch May 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GH_ENTERPRISE_URL is not reflected in generated link for Author
3 participants
@jonasbreuer @jmeridth @zkoppert