Support custom serialization for Session::CookieStore

[gregose]

This change provides the ability to specify a custom serializer for the CookieStore. In order to use serializers which only support base types, the FlashHash object has to support (de)serialization to/from plain Ruby hashes. FlashHash changes were made by porting over the Rails 2 portions of Envato's Rails 4 flash backport, h/t @charliesome .

/cc @josh @mastahyeti @ptoomey3 @dbussink

[gregose]

This also updates the AbstractStore to access hash keys with indifferent access, allowing for serializers that don't support serializing symbol keys.

[haileys]

Cool. We'll also need to make sure we get these changes into the 3-0-github branch.

[haileys]

What do we do in the Rails 3.x case?

[gregose]

For this branch we should only receive a FlashHash (only during transition period) or Hash. I still need to update 3.0 with 3.x specific changes.

[haileys]

So if we're also changing 3.x to use a Rails 4 hash then we don't need to handle it specially here? OK, I see.

[btoews]

🆒 I'm excited to see this happen. I'm wondering though if we could save ourselves some of the string vs sym key difficulties by using a HashWithIndifferentAccess?

[btoews]

Alternatively, JSON.parse accepts :symbolize_names => true if we always wanted to have the keys symobolized.

[gregose]

I'm wondering though if we could save ourselves some of the string vs sym key difficulties by using a HashWithIndifferentAccess?

I thought about this, but appears that upstream Rails 4 has indifferent access but does not use HashWithIndifferentAccess: https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/flash.rb. I have tried to stay consistent with upstream in f46a4ba.

[btoews]

🆒

On Tue, Apr 29, 2014 at 5:23 PM, Greg Ose [email protected] wrote:

I'm wondering though if we could save ourselves some of the string vs sym
key difficulties by using a HashWithIndifferentAccess?

I thought about this, but appears that upstream Rails 4 has indifferent
access but does not use HashWithIndifferentAccess:
https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/flash.rb.
I have tried to stay consistent with upstream in f46a4bahttps://github.com/github/rails/commit/f46a4bab085ef0221b8c6a4abfcfbf8c059ed15e
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/64#issuecomment-41690455
.

-Ben Toews

[btoews]

Above you are prefer the to_s ones, but here you prefer the non to_s one.

[gregose]

@charliesome i dont think you bumped this last change