Fix support for mutliple script hashes #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/secure_headers/script_hash.rb
Outdated
There exists a bug which causes ian improperly formatted `script-src`
expression for multiple script hashes. As is, the output for two hash
`abcde` and `fjhij` is:
script-src 'sha256-abcde fghij'
This should be:
script-src 'sha256-abcde' 'sha256-fghij'
spikebrehm
force-pushed
the
fix-multiple-script-hash
branch
from
2045295 to
777f913
Compare
Author
|
Strange, the build failure appears to be due to missing/mismatched RSpec features? https://travis-ci.org/twitter/secureheaders/jobs/34242758 |
Contributor
|
Yeah, the branch is very old. I'm going to assume merging/rebasing master fixes this. I'll attempt to do so right now. |
oreoshake
added a commit
that referenced
this pull request
Sep 3, 2014
Fix support for mutliple script hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists a bug which causes ian improperly formatted
script-srcexpression for multiple script hashes. As is, the output for two hash
abcdeandfjhijis:This should be: