Skip to content

test & fix for mangled tagger names #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2011

Conversation

orestis
Copy link
Contributor

@orestis orestis commented May 1, 2011

I've found and fixed an issue where the tagger names where not parsed correctly.

The root cause was that the 'tagger' prefix was stripped before passed on to the parse_actor_and_date function, so the first name of the author was consumed by the RE instead. I've changed the code to pass the whole line to the parse_actor_and_date function, as it is done in git/objects/commit.py and it fixes the issue.

@Byron Byron merged commit e7fa5ef into gitpython-developers:master May 2, 2011
@Byron
Copy link
Member

Byron commented May 2, 2011

Hi Orestis,

Thanks for your fix and test, which appear to work fine. I wonder how the test-suite could not have noticed that issue, maybe I didn't test the tagger name specifically.

Thank you,
Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants