Skip to content

add author and committer in params of the commit function #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2014
Merged

add author and committer in params of the commit function #146

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d0473c
update commit function
dralliw Mar 24, 2014
5d602f2
add param to create_from_tree
dralliw Mar 24, 2014
28fdf05
correct log reference
dralliw Mar 24, 2014
4a7e7a7
Update symbolic.py
dralliw Mar 24, 2014
3a1e0d7
fix syntax error
dralliw Apr 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct log reference
  • Loading branch information
@dralliw
dralliw committed Mar 24, 2014
commit 28fdf05b1d7827744b7b70eeb1cc66d3afd38c82
2 changes: 1 addition & 1 deletion git/refs/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def append_entry(cls, config_reader, filepath, oldbinsha, newbinsha, message):
raise ValueError("Shas need to be given in binary format")
#END handle sha type
assure_directory_exists(filepath, is_file=True)
entry = RefLogEntry((bin_to_hex(oldbinsha), bin_to_hex(newbinsha), Actor.committer(config_reader), (int(time.time()), time.altzone), message))
entry = RefLogEntry((bin_to_hex(oldbinsha), bin_to_hex(newbinsha), config_reader, (int(time.time()), time.altzone), message))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config_reader is now actually just the Actor instance of the committer. It would be very confusing to leave that name.
Also it breaks the API due to the type change. Code must be added to check the type of the input and act accordingly.


lf = LockFile(filepath)
lf._obtain_lock_or_raise()
Expand Down