Skip to content

Improve Python version and OS compatibility, fixing deprecations #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 12, 2023
Merged

Improve Python version and OS compatibility, fixing deprecations #1654

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
dba4245
Fix installation test for Python 3.12 and Windows
EliahKagan Sep 9, 2023
72e48aa
Update installation instructions in readme
EliahKagan Sep 10, 2023
b095aa9
Use more compatible hashbangs
EliahKagan Sep 10, 2023
63c4624
Don't duplicate packages across requirements files
EliahKagan Sep 10, 2023
3aacb37
Use a "test" extra instead of tests_require
EliahKagan Sep 10, 2023
e1d8b40
Use "build" for building
EliahKagan Sep 10, 2023
b9b6d8c
Ungroup and sort test_requirements.txt
EliahKagan Sep 10, 2023
21c5f87
Don't preinstall dependencies in test_installation
EliahKagan Sep 10, 2023
6b54890
Test changed setup, and Python 3.12, on CI
EliahKagan Sep 10, 2023
055355d
Don't use "set -x" for "pytest" command on Cygwin
EliahKagan Sep 10, 2023
a352404
List Python 3.12 as supported in setup.py
EliahKagan Sep 10, 2023
415a8eb
Small clarity improvements in setup.py
EliahKagan Sep 10, 2023
4eef3ec
Have actions/checkout do the full fetch
EliahKagan Sep 11, 2023
5f128e8
Move effect of "set -x" into default shell command
EliahKagan Sep 11, 2023
d99b2d4
prepare next release
Byron Sep 11, 2023
f86f09e
Make publish process possible on MacOS
Byron Sep 11, 2023
5343aa0
Let "make" install build and twine if in a virtual environment
EliahKagan Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small clarity improvements in setup.py
  • Loading branch information
@EliahKagan
EliahKagan committed Sep 10, 2023
commit 415a8ebdf8d0648cd17218e817963721d8df54da
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
import os
import sys

with open(os.path.join(os.path.dirname(__file__), "VERSION")) as v:
VERSION = v.readline().strip()
with open(os.path.join(os.path.dirname(__file__), "VERSION")) as ver_file:
VERSION = ver_file.readline().strip()

with open("requirements.txt") as reqs_file:
requirements = reqs_file.read().splitlines()
Expand Down Expand Up @@ -49,7 +49,7 @@ def _stamp_version(filename: str) -> None:
with open(filename) as f:
for line in f:
if "__version__ =" in line:
line = line.replace("\"git\"", "'%s'" % VERSION)
line = line.replace('"git"', "'%s'" % VERSION)
found = True
out.append(line)
except OSError:
Expand Down