Skip to content

Fix bugs affecting exception wrapping in rmtree callback #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Fix bugs affecting exception wrapping in rmtree callback #1700

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2814263
Add a missing PermissionError xfail on Windows
EliahKagan Oct 8, 2023
fba59aa
Update "ACTUALLY skipped by" comments
EliahKagan Oct 8, 2023
5039df3
Eliminate duplicate rmtree try-except logic
EliahKagan Oct 8, 2023
683a3ee
Clean up git.objects.submodule.base imports
EliahKagan Oct 8, 2023
2fe7f3c
Test current expected behavior of git.util.rmtree
EliahKagan Oct 9, 2023
d42cd72
Test situations git.util.rmtree shouldn't wrap
EliahKagan Oct 9, 2023
2a32e25
Fix test bug that assumed staticmethod callability
EliahKagan Oct 9, 2023
b8e009e
In rmtree, have onerror catch only PermissionError
EliahKagan Oct 8, 2023
ccbb273
Fix onerror callback type hinting, improve style
EliahKagan Oct 8, 2023
0b88012
Use onexc callback where supported
EliahKagan Oct 9, 2023
7dd5904
Revise and update rmtree docstrings and comments
EliahKagan Oct 9, 2023
196cfbe
Clean up test_util, reorganizing for readability
EliahKagan Oct 9, 2023
100ab98
Add initial test_env_vars_for_windows_tests
EliahKagan Oct 7, 2023
7604da1
Warn if HIDE_WINDOWS_*_ERRORS set in environment
EliahKagan Oct 7, 2023
eb51277
Make HIDE_* attributes always bool
EliahKagan Oct 7, 2023
333896b
Treat false-seeming HIDE_* env var values as false
EliahKagan Oct 7, 2023
c11b366
Simplify HIDE_* env var test; add missing cases
EliahKagan Oct 7, 2023
f0e15e8
Further cleanup in test_util (on new tests)
EliahKagan Oct 9, 2023
a9b05ec
Clarify a test helper docstring
EliahKagan Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify a test helper docstring 
The wording was ambiguous before, because fixing a PermissionError
could mean addressing it successfully at runtime (which is the
intended meaning in that docstring) but it could also mean fixing
a bug or test case related to such an error (not intended).
  • Loading branch information
@EliahKagan
EliahKagan committed Oct 9, 2023
commit a9b05ece674578d3417f8969ade17b06ab287ffe
2 changes: 1 addition & 1 deletion test/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def __repr__(self):

@contextlib.contextmanager
def _tmpdir_to_force_permission_error():
"""Context manager to test permission errors in situations where we do not fix them."""
"""Context manager to test permission errors in situations where they are not overcome."""
if sys.platform == "cygwin":
raise SkipTest("Cygwin can't set the permissions that make the test meaningful.")
if sys.version_info < (3, 8):
Expand Down