Fix test-only issue with git 2.20 or later handling a clobbered tag #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves the python 3.7 CI build issue. The Appveyor issues are known failures and will be addressed in upcoming builds. Please merge this so that I can continue submitting PRs that build on it. |
|
@Byron if you could please commit this, it fixes Travis CI. Then I will work on AppVeyor and the setup tooling issues. |
|
Could anyone possibly merge this to improve the CI experience? I have more pull request following this that will do things like clean up the errors in setup.py... but I'd like to get to a clean CI build first. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added the xenial image on Travis CI, it came with a git upgrade. Xenial usually has git 2.7.4 but the one on travis has 2.20.1. In version 2.20 there were changes around how tags can be clobbered (or not):
git/git@0bc8d71
The test suite was relying on the old behavior, so we had to adjust the test.