Skip to content

use gix_path::env::shell() to get the shell in git2-hooks #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

use gix_path::env::shell() to get the shell in git2-hooks #2612

merged 2 commits into from
Apr 16, 2025

Conversation

Joshix-1
Copy link
Contributor

This deals with one half of #2611

It changes the following:

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@Joshix-1 Joshix-1 marked this pull request as ready for review April 15, 2025 13:23
naseschwarz
naseschwarz suggested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@naseschwarz naseschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Joshix-1. I have just one remark.

@Joshix-1 @naseschwarz
Update git2-hooks/Cargo.toml
674055c 
Co-authored-by: Johannes Agricola <[email protected]>
@Byron Byron mentioned this pull request Apr 16, 2025
Closed
Byron
Byron approved these changes Apr 16, 2025
View reviewed changes
Copy link

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again!

Please note that gix-path will probably increment its major version every couple of months, but I don't expect any actual breakage here so that should be fine.

@extrawurst extrawurst merged commit 0e37671 into gitui-org:master Apr 16, 2025
22 checks passed
@extrawurst
Copy link
Collaborator

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

@naseschwarz naseschwarz naseschwarz approved these changes

Assignees
No one assigned
Labels
merge_ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joshix-1 @extrawurst @Byron @naseschwarz