Skip to content

Clean up a few #[allow]s #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2025
Merged

Clean up a few #[allow]s #2614

merged 6 commits into from
Apr 16, 2025

Conversation

naseschwarz
Copy link
Contributor

@naseschwarz naseschwarz commented Apr 16, 2025 •
edited
Loading

It changes the following:

  • Removes a few outdated or easy to fix #[allow]s

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
    • Explicitly tested the ghemoji feature
  • I added an appropriate item to the changelog

@naseschwarz
Copy link
Contributor Author

naseschwarz commented Apr 16, 2025 •
edited
Loading

This brings rg '#.*allow' | wc -l from 38 down to 31 28.

Naseschwarz added 2 commits April 16, 2025 10:34
Disallow fixed clippy::needless_borrow
b32b03d
Move string through emojifi_string
5c1fb12 
This avoids unnecessary mut magic outside of this function
@extrawurst extrawurst merged commit e08d954 into gitui-org:master Apr 16, 2025
22 checks passed
@extrawurst
Copy link
Collaborator

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naseschwarz @extrawurst