Skip to content

Add new line support for multi-line input box #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 35 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2ccdf8f
Add input multi-line support
WizardOhio24 Feb 8, 2021
0a0046e
Remove incorrect ;
WizardOhio24 Feb 8, 2021
fb8bd52
Only allow inserting new line if input type is multiline
WizardOhio24 Feb 8, 2021
3d4ae7e
Add command for new line when commit box is open
WizardOhio24 Feb 18, 2021
1a219a1
Change to use defined ALT symbol
WizardOhio24 Feb 18, 2021
e464a67
Merge branch 'master' into multi-line-commit
WizardOhio24 Apr 16, 2021
de9eeaa
Change commit key to alt c and newline to enter
WizardOhio24 Apr 16, 2021
470f895
commit via ctrl+o
Apr 17, 2021
6c8b6aa
Merge branch 'master' into multi-line-commit
WizardOhio24 Apr 29, 2021
b012557
Fix build use EventState
WizardOhio24 Apr 29, 2021
424c4ce
Fix build
WizardOhio24 Apr 29, 2021
6864122
Merge branch 'master' into multi-line-commit
WizardOhio24 May 23, 2021
24183ac
Add scrolling behaviour
WizardOhio24 May 23, 2021
3f32e0a
Add scrollbar
WizardOhio24 May 23, 2021
cc5b6da
Fix clippy errors
WizardOhio24 May 23, 2021
62aee74
Try to fix scrolling
WizardOhio24 May 25, 2021
95ba92d
Fix scrolling behaviour on incriment and decrement cursor
WizardOhio24 May 25, 2021
28cc411
Fix scrollbar scrolling
WizardOhio24 May 25, 2021
ace7f01
Fix up and down arrow scrolling
WizardOhio24 May 25, 2021
5de0171
Fix clippy and remove unused variable
WizardOhio24 May 25, 2021
23764d6
Remove unessessary comments
WizardOhio24 May 25, 2021
4923d6f
Fix intersperse clippy error
WizardOhio24 May 25, 2021
135c8c5
Textbox resize to number of lines
WizardOhio24 May 25, 2021
421d4d6
Show scrollbar only if text area larger than frame
WizardOhio24 May 25, 2021
4b66809
Scroll up when backspace over newline char
WizardOhio24 May 25, 2021
9925ea9
Revert keys formatting
WizardOhio24 May 25, 2021
a4dbd6e
Remove else if input event consumed
WizardOhio24 May 25, 2021
aa7da1e
Merge branch 'master' into multi-line-commit
WizardOhio24 May 25, 2021
be36c54
Make command for newline only show on multiline textboxes
WizardOhio24 May 25, 2021
8d44559
Add some comments and seperation between single and multiline
WizardOhio24 May 25, 2021
51d38e2
Fix build
WizardOhio24 May 25, 2021
efb948d
Fix clippy error
WizardOhio24 May 25, 2021
aafd928
Change ends in nl to add a span
WizardOhio24 May 25, 2021
424e865
Fix moving down a line
WizardOhio24 May 25, 2021
a51fb26
Some fixes
WizardOhio24 May 27, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove else if input event consumed
  • Loading branch information
WizardOhio24 committed May 25, 2021
commit a4dbd6e78901e5f8f4b00d0d1fe725ec49073cdc
3 changes: 1 addition & 2 deletions src/components/commit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,8 @@ impl Component for CommitComponent {
InternalEvent::OpenExternalEditor(None),
);
self.hide();
} else if self.input.event(ev)?.is_consumed() {
return Ok(EventState::Consumed);
}

// stop key event propagation
return Ok(EventState::Consumed);
}
Expand Down