LFS file download from UI

cmd/web.go

@@ -567,6 +567,7 @@ func runWeb(ctx *cli.Context) error {
 		m.Group("/:reponame", func() {
 			m.Group("/info/lfs", func() {
 				m.Post("/objects/batch", lfs.BatchHandler)
+				m.Get("/objects/:oid/:filename", lfs.ObjectOidHandler)
 				m.Any("/objects/:oid", lfs.ObjectOidHandler)
 				m.Post("/objects", lfs.PostHandler)
 			}, ignSignInAndCsrf)

modules/lfs/server.go

@@ -83,7 +83,7 @@ func ObjectOidHandler(ctx *context.Context) {
 			GetMetaHandler(ctx)
 			return
 		}
-		if ContentMatcher(ctx.Req) {
+		if ContentMatcher(ctx.Req) || ctx.IsSigned {
 			GetContentHandler(ctx)
 			return
 		}
@@ -112,7 +112,7 @@ func GetContentHandler(ctx *context.Context) {
 		return
 	}
 
-	if !authenticate(repository, rv.Authorization, false) {
+	if !authenticate(ctx, repository, rv.Authorization, false) {
 		requireAuth(ctx)
 		return
 	}
@@ -137,6 +137,17 @@ func GetContentHandler(ctx *context.Context) {
 		return
 	}
 
+	ctx.Resp.Header().Set("Content-Length", strconv.FormatInt(meta.Size, 10))
+	ctx.Resp.Header().Set("Content-Type", "application/octet-stream")
+
+	filename := ctx.Params("filename")
+	if len(filename) > 0 {
+		decodedFilename, err := base64.RawURLEncoding.DecodeString(filename)
+		if err == nil {
+			ctx.Resp.Header().Set("Content-Disposition", "attachment; filename=\""+string(decodedFilename)+"\"")
+		}
+	}
+
 	ctx.Resp.WriteHeader(statusCode)
 	io.Copy(ctx.Resp, content)
 	content.Close()
@@ -161,7 +172,7 @@ func GetMetaHandler(ctx *context.Context) {
 		return
 	}
 
-	if !authenticate(repository, rv.Authorization, false) {
+	if !authenticate(ctx, repository, rv.Authorization, false) {
 		requireAuth(ctx)
 		return
 	}
@@ -200,7 +211,7 @@ func PostHandler(ctx *context.Context) {
 		return
 	}
 
-	if !authenticate(repository, rv.Authorization, true) {
+	if !authenticate(ctx, repository, rv.Authorization, true) {
 		requireAuth(ctx)
 	}
 
@@ -259,7 +270,7 @@ func BatchHandler(ctx *context.Context) {
 			requireWrite = true
 		}
 
-		if !authenticate(repository, object.Authorization, requireWrite) {
+		if !authenticate(ctx, repository, object.Authorization, requireWrite) {
 			requireAuth(ctx)
 			return
 		}
@@ -307,7 +318,7 @@ func PutHandler(ctx *context.Context) {
 		return
 	}
 
-	if !authenticate(repository, rv.Authorization, true) {
+	if !authenticate(ctx, repository, rv.Authorization, true) {
 		requireAuth(ctx)
 		return
 	}
@@ -428,7 +439,17 @@ func logRequest(r macaron.Request, status int) {
 
 // authenticate uses the authorization string to determine whether
 // or not to proceed. This server assumes an HTTP Basic auth format.
-func authenticate(repository *models.Repository, authorization string, requireWrite bool) bool {
+func authenticate(ctx *context.Context, repository *models.Repository, authorization string, requireWrite bool) bool {
+
+	accessMode := models.AccessModeRead
+	if requireWrite {
+		accessMode = models.AccessModeWrite
+	}
+
+	if ctx.IsSigned {
+		accessCheck, _ := models.HasAccess(ctx.User, repository, accessMode)
+		return accessCheck
+	}
 
 	if !repository.IsPrivate && !requireWrite {
 		return true
@@ -466,11 +487,6 @@ func authenticate(repository *models.Repository, authorization string, requireWr
 		return false
 	}
 
-	accessMode := models.AccessModeRead
-	if requireWrite {
-		accessMode = models.AccessModeWrite
-	}
-
 	accessCheck, _ := models.HasAccess(userModel, repository, accessMode)
 	return accessCheck
 }

options/locale/locale_en-US.ini

@@ -434,6 +434,7 @@ file_view_raw = View Raw
 file_permalink = Permalink
 file_too_large = This file is too large to be shown
 video_not_supported_in_browser = Your browser doesn't support HTML5 video tag.
+stored_lfs = Stored with Git LFS
 
 editor.new_file = New file
 editor.upload_file = Upload file

routers/repo/view.go

@@ -17,11 +17,14 @@ import (
 	"code.gitea.io/gitea/modules/base"
 	"code.gitea.io/gitea/modules/context"
 	"code.gitea.io/gitea/modules/highlight"
+	"code.gitea.io/gitea/modules/lfs"
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/markdown"
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/templates"
+	"encoding/base64"
 	"github.com/Unknwon/paginater"
+	"strconv"
 )
 
 const (
@@ -139,6 +142,29 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st
 	isTextFile := base.IsTextFile(buf)
 	ctx.Data["IsTextFile"] = isTextFile
 
+	//Check for LFS meta file
+	if isTextFile {
+		headString := string(buf)
+		if strings.HasPrefix(headString, "version https://git-lfs.github.com/spec/v1") {
+			splitLines := strings.Split(headString, "\n")
+			if len(splitLines) >= 3 {
+				oid := strings.TrimPrefix(splitLines[1], "oid sha256:")
+				size, err := strconv.ParseInt(strings.TrimPrefix(splitLines[2], "size "), 10, 64)
+				if len(oid) == 64 && err == nil {
+					contentStore := &lfs.ContentStore{BasePath: setting.LFS.ContentPath}
+					meta := &models.LFSMetaObject{Oid: oid}
+					if contentStore.Exists(meta) {
+						ctx.Data["IsTextFile"] = false
+						ctx.Data["IsLFSFile"] = true
+						ctx.Data["FileSize"] = size
+						filenameBase64 := base64.RawURLEncoding.EncodeToString([]byte(blob.Name()))
+						ctx.Data["RawFileLink"] = fmt.Sprintf("%s%s/info/lfs/objects/%s/%s", setting.AppURL, ctx.Repo.Repository.FullName(), oid, filenameBase64)
+					}
+				}
+			}
+		}
+	}
+
 	// Assume file is not editable first.
 	if !isTextFile {
 		ctx.Data["EditFileTooltip"] = ctx.Tr("repo.editor.cannot_edit_non_text_files")

templates/repo/view_file.tmpl

@@ -5,11 +5,11 @@
 			{{if .ReadmeInList}}
 				<strong>{{.FileName}}</strong>
 			{{else}}
-				<strong>{{.FileName}}</strong> <span class="text grey normal">{{FileSize .FileSize}}</span>
+				<strong>{{.FileName}}</strong> <span class="text grey normal">{{FileSize .FileSize}}{{if .IsLFSFile}} ({{.i18n.Tr "repo.stored_lfs"}}){{end}}</span>
 			{{end}}
 		{{else}}
 			<i class="file text outline icon ui left"></i>
-			<strong>{{.FileName}}</strong> <span class="text grey normal">{{FileSize .FileSize}}</span>
+			<strong>{{.FileName}}</strong> <span class="text grey normal">{{FileSize .FileSize}}{{if .IsLFSFile}} ({{.i18n.Tr "repo.stored_lfs"}}){{end}}</span>
 		{{end}}
 		{{if not .ReadmeInList}}
 			<div class="ui right file-actions">