Keep database transactions not too big #13254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Also need to be nicer with missing repositories too |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
Oct 22, 2020
GiteaBot
added
lgtm/need 1
|
See: lunny#9 |
zeripath
reviewed
Oct 22, 2020
models/migrations/v156.go
Outdated
| if err := sess.Begin(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var ( | ||
| gitRepoCache = make(map[int64]*git.Repository) |
There was a problem hiding this comment.
We may need to limit the size of this or... perhaps even better just order the releases by repository ID
Codecov Report
@@ Coverage Diff @@
## master #13254 +/- ##
==========================================
+ Coverage 42.15% 42.17% +0.01%
==========================================
Files 684 684
Lines 75540 75544 +4
==========================================
+ Hits 31847 31861 +14
+ Misses 38468 38460 -8
+ Partials 5225 5223 -2
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Thornton <[email protected]>
Only cache the last repo
zeripath
approved these changes
Oct 22, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You don't know if the Gitea instance has how many releases which maybe over the capacity of the databases. So we should keep the transaction as a suitable size.
Also:
Fix #13255