fixed bug #151 finally #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I didn't understand what #151 was about but this change LGTM |
|
Yep, I don't see any relationship there too. But we should log that nevertheless. |
Current coverage is 3.03% (diff: 100%)@@ master #164 diff @@
========================================
Files 33 33
Lines 8093 8093
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 246 246
Misses 7827 7827
Partials 20 20
|
|
Yes, I will document it. The rule is |
tboerger
added
the
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #151 described, found
remote: 2016/11/12 10:27:43 <nil>. So this is because commandservorupdateoutput some error to the standard output. but don't find anyfmt.Printlnand finally, find the main.go. Spend me so many time.