Skip to content

Rework mailer settings #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 2, 2022
Merged

Rework mailer settings #18982

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d60c438
Rework mailer settings (fixes #18901)
clarfonthey Mar 2, 2022
bc7b454
Do proper check if SMTP_ADDR is local IP
clarfonthey May 3, 2022
a4736f8
Reword insecure SMTP warning
clarfonthey May 8, 2022
7e0a30c
Merge branch 'main' into mailer-settings
wxiaoguang Jul 14, 2022
294ddd6
Merge branch 'main' into mailer-settings
wxiaoguang Jul 28, 2022
5f1d299
fix comments to "be removed in v1.19.0"
wxiaoguang Jul 28, 2022
dad722e
only use deprecated key if the new key doesn't exist
wxiaoguang Jul 28, 2022
ae30251
sync document and options
wxiaoguang Jul 28, 2022
8d20702
fix smtp fields in installation page
wxiaoguang Jul 28, 2022
360e32e
fix markdown lint
wxiaoguang Jul 28, 2022
12c00fd
fix i18n
wxiaoguang Jul 28, 2022
4ecb4e8
Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
wxiaoguang Jul 28, 2022
466d6ba
Update custom/conf/app.example.ini
wxiaoguang Jul 28, 2022
4fbdc26
Update config-cheat-sheet.en-us.md
clarfonthey Jul 29, 2022
45df0a6
Update app.example.ini
clarfonthey Jul 29, 2022
be36a99
Update docs to make conversion between settings clearer
clarfonthey Jul 29, 2022
c14ec6c
fix lint errors
wxiaoguang Jul 30, 2022
60cf9a8
Merge branch 'main' into mailer-settings
wxiaoguang Jul 30, 2022
8e0d486
Merge branch 'main' into mailer-settings
lunny Jul 30, 2022
0556044
Merge branch 'main' into mailer-settings
lunny Jul 31, 2022
48d7743
Merge branch 'main' into mailer-settings
wxiaoguang Aug 1, 2022
06792df
Merge branch 'main' into mailer-settings
lunny Aug 1, 2022
8e3f70b
Merge branch 'main' into mailer-settings
wxiaoguang Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reword insecure SMTP warning
  • Loading branch information
@clarfonthey
clarfonthey committed May 8, 2022
commit a4736f8a0af0ed0ff76f7d64a517d882f912344f
2 changes: 1 addition & 1 deletion modules/setting/mailer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func newMailService() {
if MailService.Protocol == "smtp" {
for _, ip := range ips {
if !ip.IsLoopback() {
log.Warn("connect via insecure SMTP to non-local address")
log.Warn("connecting over insecure SMTP protocol to non-local address is not recommended")
break
}
}
Expand Down