Skip to content

Fix remove file on initial comment #20127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Fix remove file on initial comment #20127

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e22707
Fix remove file on initial comment
Jun 24, 2022
9e75aa1
Extend fix
Jun 25, 2022
b558087
Merge branch 'main' into store-file-uuid
Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix remove file on initial comment 
- Store the file uuid(which is returned by Gitea in the upload file
response) onto the file object, so it can be used for the remove feature
to specify this file.
- Resolves #20115
  • Loading branch information
Gusted committed Jun 24, 2022
commit 6e22707bed12be15ec57669273910143d8ab0dc6
3 changes: 2 additions & 1 deletion web_src/js/features/common-global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ export function initGlobalDropzone() {
thumbnailWidth: 480,
thumbnailHeight: 480,
init() {
this.on('success', (_file, data) => {
this.on('success', (file, data) => {
file.uuid = data.uuid;
const input = $(`<input id="${data.uuid}" name="files" type="hidden">`).val(data.uuid);
$dropzone.find('.files').append(input);
});
Expand Down