Skip to content

Fix error when calculate the repository size #22392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Fix error when calculate the repository size #22392

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e634e8c
Fix error when calculate the repository size
lunny Jan 10, 2023
2696577
Apply suggestions from code review
lunny Jan 11, 2023
a861128
Apply suggestions from code review
lunny Jan 11, 2023
9e33fdf
Merge branch 'main' into lunny/fix_error_when_calculate_repo_size
lunny Jan 12, 2023
438fc93
Fix bug
lunny Jan 13, 2023
9252c7a
Merge branch 'main' into lunny/fix_error_when_calculate_repo_size
lunny Jan 13, 2023
ec83367
Merge branch 'lunny/fix_error_when_calculate_repo_size' of github.com…
lunny Jan 13, 2023
d0b78c0
Merge branch 'main' into lunny/fix_error_when_calculate_repo_size
lunny Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bug
  • Loading branch information
@lunny
lunny committed Jan 13, 2023
commit 438fc931920f638ffc4259d99cbaeaa0de12e362
10 changes: 8 additions & 2 deletions modules/repository/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,20 @@ const notRegularFileMode os.FileMode = os.ModeSymlink | os.ModeNamedPipe | os.Mo
func getDirectorySize(path string) (int64, error) {
var size int64
err := filepath.WalkDir(path, func(_ string, info os.DirEntry, err error) error {
if os.IsNotExist(err) || info.IsDir() {
if err != nil {
if os.IsNotExist(err) { // ignore the error because the file maybe deleted during traversing.
return nil
}
return err
}
if info.IsDir() {
return nil
}
f, err := info.Info()
if err != nil {
return err
}
if info != nil && (f.Mode()&notRegularFileMode) == 0 {
if (f.Mode() & notRegularFileMode) == 0 {
size += f.Size()
}
return err
Expand Down