Skip to content

Fix environments for KaTeX and error reporting #22453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Fix environments for KaTeX and error reporting #22453

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0121067
Fix environments for KaTeX and error reporting
zeripath Jan 15, 2023
f273f57
Merge branch 'main' into fix-22447-katex-environments-and-error-display
lunny Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix environments for KaTeX and error reporting 
In #22447 it was noticed that display environments were not working
correctly. This was due to the setting displayMode not being set.

Further it was noticed that the error was not being displayed correctly.

This PR fixes both of these issues by forcibly setting the displayMode
setting and corrects an error in displayError.

Fix #22447

Signed-off-by: Andrew Thornton <[email protected]>
  • Loading branch information
@zeripath
zeripath committed Jan 15, 2023
commit 01210675c90f69d175b598ff34dcc5e55bb36f94
6 changes: 4 additions & 2 deletions web_src/js/markup/math.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function displayError(el, err) {
const target = targetElement(el);
target.remove('is-loading');
target.classList.remove('is-loading');
const errorNode = document.createElement('div');
errorNode.setAttribute('class', 'ui message error markup-block-error mono');
errorNode.textContent = err.str || err.message || String(err);
Expand All @@ -23,13 +23,15 @@ export async function renderMath() {

for (const el of els) {
const source = el.textContent;
const nodeName = el.classList.contains('display') ? 'p' : 'span';
const displayMode = el.classList.contains('display');
const nodeName = displayMode ? 'p' : 'span';

try {
const tempEl = document.createElement(nodeName);
katex.render(source, tempEl, {
maxSize: 25,
maxExpand: 50,
displayMode,
});
targetElement(el).replaceWith(tempEl);
} catch (error) {
Expand Down