Skip to content

Improve checkIfPRContentChanged #22611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 28, 2023
Merged

Improve checkIfPRContentChanged #22611

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3628e2b
Improve checkIfPRContentChanged
zeripath Jan 26, 2023
6754c27
not-equals
zeripath Jan 26, 2023
5d2dd5e
use pipeline to properly prevent reading in too many files names
zeripath Jan 26, 2023
0b21de0
Update services/pull/pull.go
zeripath Jan 27, 2023
bd0f20b
Merge branch 'main' into improve-checkIfPRContentChanged
zeripath Jan 27, 2023
962ea92
Merge branch 'main' into improve-checkIfPRContentChanged
zeripath Jan 27, 2023
c2d786e
as per delvh
zeripath Jan 27, 2023
98ac325
more
zeripath Jan 27, 2023
54410ce
remove duplication in error report
zeripath Jan 27, 2023
2dc44c6
Update modules/util/io.go
zeripath Jan 28, 2023
7cb1874
Merge branch 'main' into improve-checkIfPRContentChanged
lunny Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update services/pull/pull.go 
Co-authored-by: delvh <[email protected]>
  • Loading branch information
@zeripath @delvh
zeripath and delvh authored Jan 27, 2023
commit 0b21de075b75b625e481ff5979a4cfcc2bff67fe
2 changes: 1 addition & 1 deletion services/pull/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
func checkIfPRContentChanged(ctx context.Context, pr *issues_model.PullRequest, oldCommitID, newCommitID string) (hasChanged bool, err error) {
tmpBasePath, err := createTemporaryRepo(ctx, pr)
if err != nil {
log.Error("CreateTemporaryPath: %v", err)
log.Error("CreateTemporaryRepo: %v", err)
return false, err
}
defer func() {
Expand Down