Skip to content

Fix bugs with WebAuthn preventing sign in and registration. #22651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 1, 2023
Merged

Fix bugs with WebAuthn preventing sign in and registration. #22651

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df2adb2
Fix Uncaught DOMException: Failed to execute 'atob' on 'Window'
zeripath Jan 29, 2023
f40e516
Update web_src/js/features/user-auth-webauthn.js
zeripath Jan 29, 2023
07e40bd
Merge branch 'main' into fix-atob-on-window
zeripath Jan 29, 2023
dcd6307
Include findings from #22654
zeripath Jan 29, 2023
4a910b9
Merge remote-tracking branch 'zeripath/fix-atob-on-window' into fix-a…
zeripath Jan 29, 2023
f038244
As per wxiaoguang
zeripath Jan 30, 2023
6326456
Merge branch 'main' into fix-atob-on-window
zeripath Jan 30, 2023
7864ed8
Merge branch 'main' into fix-atob-on-window
zeripath Jan 31, 2023
b37e6a1
fix test
zeripath Jan 31, 2023
3bc0753
Merge branch 'main' into fix-atob-on-window
lunny Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_src/js/features/user-auth-webauthn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import $ from 'jquery';

const {appSubUrl, csrfToken} = window.config;

function encodeToBase64(toEncode) {
function encodeToBase64(toEncode /* Uint8Array */) {
const output = [];
for (let i = 0; i < toEncode.length; i++) {
output.push(String.fromCharCode(toEncode[i]));
Expand Down