Skip to content

Add command to bulk set must-change-password #22823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 14, 2023
Merged

Add command to bulk set must-change-password #22823

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
30e6387
Add command to bulk set must-change-password
zeripath Feb 8, 2023
96a223d
fix fmt
zeripath Feb 8, 2023
0532d4c
Update docs/content/doc/usage/command-line.en-us.md
zeripath Feb 10, 2023
f8ac8d6
Update docs/content/doc/usage/command-line.en-us.md
zeripath Feb 10, 2023
5aa6a5a
Apply suggestions from code review
zeripath Feb 10, 2023
f72e09d
Merge branch 'main' into admin-command-all-must-change-password
zeripath Feb 11, 2023
672bea3
Merge remote-tracking branch 'origin/main' into admin-command-all-mus…
zeripath Feb 12, 2023
1767d8c
placate linter
zeripath Feb 12, 2023
85ccc7a
Merge branch 'main' into admin-command-all-must-change-password
zeripath Feb 13, 2023
a788b59
Merge branch 'main' into admin-command-all-must-change-password
jolheiser Feb 14, 2023
01cd5ea
use []string
zeripath Feb 14, 2023
1a1169a
Merge branch 'main' into admin-command-all-must-change-password
zeripath Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/content/doc/usage/command-line.en-us.md 
Co-authored-by: delvh <[email protected]>
  • Loading branch information
@zeripath @delvh
zeripath and delvh authored Feb 10, 2023
commit 0532d4c1d46589a791eca1859c1b37c553a09331
2 changes: 1 addition & 1 deletion docs/content/doc/usage/command-line.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Admin operations:
- Args:
- `[username...]`: Users to set MustChangePassword for
- Options:
- `--all`, `-A`: Set MustChangePassword for all users
- `--all`, `-A`: Force a password change for all users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, why -A and not -a?
As far as I can see, it's the only sub-command with a capital letter…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I thought --all tended to be -A but I don't mind making it -a if others prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that -A seems less likely to mistyped, but that's just an observation. I am okay with either one.

- `--exclude [username,username...]`, `-e [...]`: Exclude the given users
- `--unset`: Instead of setting MustChangePassword, unset it
- `regenerate`
Expand Down