Skip to content

Load issue before accessing index in merge message (#22822) #22830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Load issue before accessing index in merge message (#22822) #22830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a464662
Load issue before accessing index in merge message (#22822)
jolheiser Feb 9, 2023
20628b5
fix: remove new changes from backport
jolheiser Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove new changes from backport 
Signed-off-by: jolheiser <[email protected]>
  • Loading branch information
@jolheiser
jolheiser committed Feb 9, 2023
commit 20628b596c333b90b96eb1199437b924c109b664
4 changes: 2 additions & 2 deletions services/pull/merge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ func GetDefaultMergeMessage(baseGitRepo *git.Repository, pr *issues_model.PullRe
}
for _, ref := range refs {
if ref.RefAction == references.XRefActionCloses {
if err := ref.LoadIssue(ctx); err != nil {
return "", "", err
if err := ref.LoadIssue(); err != nil {
return "", err
}
closeIssueIndexes = append(closeIssueIndexes, fmt.Sprintf("%s %s%d", closeWord, issueReference, ref.Issue.Index))
}
Expand Down