Skip to content

Warn users when they try to use a non-root-url to sign in/up (#32272) #32273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Warn users when they try to use a non-root-url to sign in/up (#32272) #32273

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f94e3
fix
wxiaoguang Oct 16, 2024
4b9c2be
Update web_src/js/features/common-global.js
wxiaoguang Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update web_src/js/features/common-global.js
  • Loading branch information
@wxiaoguang
wxiaoguang authored Oct 16, 2024
commit 4b9c2be1cfed9a212174f3b4e2ee33b74918abc7
3 changes: 1 addition & 2 deletions web_src/js/features/common-global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,6 @@ export function checkAppUrlScheme() {
const curUrl = window.location.href;
// some users visit "http://domain" while appUrl is "https://domain", COOKIE_SECURE makes it impossible to sign in
if (curUrl.startsWith('http:') && appUrl.startsWith('https:')) {
showGlobalErrorMessage(`Your ROOT_URL in app.ini "${appUrl}" uses HTTPS, it doesn't match the HTTP site you are visiting.
Mismatched ROOT_URL config would cause problems for sign-in/sign-up, etc.`, 'warning');
showGlobalErrorMessage(`This instance is configured to run under HTTPS (by ROOT_URL config), you are accessing by HTTP. Mismatched scheme might cause problems for sign-in/sign-up.`, 'warning');
}
}