Skip to content

Support HTTP POST requests to /userinfo, aligning to OpenID Core specification #32578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Support HTTP POST requests to /userinfo, aligning to OpenID Core specification #32578

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366cbbb
add POST to /userinfo
marcellmars Nov 20, 2024
f2831a6
Merge branch 'main' into get_post_userinfo
wxiaoguang Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add POST to /userinfo 
- from OpenID Core:
 - 5.3. Userinfo Endpoint:
   - The UserInfo Endpoint MUST support the use of the HTTP GET and HTTP
     POST methods
 - 5.3.1. Userinfo Request:
   - It is RECOMMENDED that the request use the HTTP GET method and the
     Access Token be sent using the Authorization header field.
- minio sends POST request ignoring the recommendation
  • Loading branch information
@marcellmars
marcellmars committed Nov 20, 2024
commit 366cbbbac9dcce13a7980cf4dba58bf71719c2c2
2 changes: 1 addition & 1 deletion routers/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ func registerRoutes(m *web.Router) {
m.Post("/authorize", web.Bind(forms.AuthorizationForm{}), auth.AuthorizeOAuth)
}, optSignInIgnoreCsrf, reqSignIn)

m.Methods("GET, OPTIONS", "/userinfo", optionsCorsHandler(), optSignInIgnoreCsrf, auth.InfoOAuth)
m.Methods("GET, POST, OPTIONS", "/userinfo", optionsCorsHandler(), optSignInIgnoreCsrf, auth.InfoOAuth)
m.Methods("POST, OPTIONS", "/access_token", optionsCorsHandler(), web.Bind(forms.AccessTokenForm{}), optSignInIgnoreCsrf, auth.AccessTokenOAuth)
m.Methods("GET, OPTIONS", "/keys", optionsCorsHandler(), optSignInIgnoreCsrf, auth.OIDCKeys)
m.Methods("POST, OPTIONS", "/introspect", optionsCorsHandler(), web.Bind(forms.IntrospectTokenForm{}), optSignInIgnoreCsrf, auth.IntrospectOAuth)
Expand Down
Loading