Skip to content

Remove useless fmt.Errorf("%v", err) #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2018
Merged

Remove useless fmt.Errorf("%v", err) #3337

merged 2 commits into from
Jan 9, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 9, 2018 •
edited
Loading

Seeing use of it in #3328. I think of searching quickly for it on other parts of code.

@codecov-io
Copy link

codecov-io commented Jan 9, 2018 •
edited
Loading

Codecov Report

Merging #3337 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3337      +/-   ##
==========================================
+ Coverage   35.04%   35.05%   +<.01%     
==========================================
  Files         280      280              
  Lines       40556    40556              
==========================================
+ Hits        14213    14216       +3     
+ Misses      24237    24235       -2     
+ Partials     2106     2105       -1
Impacted Files Coverage Δ
routers/user/home.go 40.56% <0%> (ø) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7295f2...3b2f4b5. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2018
@thehowl
Copy link
Contributor

thehowl commented Jan 9, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2018
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 9, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 9, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2018
@andreynering andreynering merged commit 84feb01 into go-gitea:master Jan 9, 2018
@sapk sapk deleted the remove-useless-fmt-errorf branch January 15, 2018 23:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sapk @codecov-io @thehowl @lafriks @tboerger @andreynering