Skip to content

Update gitea/sdk vendor #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ethantkoenig
Copy link
Member

Brings in changes from go-gitea/go-sdk@559190d

@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 9, 2016
@lunny lunny added this to the 1.0.0 milestone Dec 9, 2016
@lunny
Copy link
Member

lunny commented Dec 9, 2016

drone failed

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2016
@ethantkoenig
Copy link
Member Author

@lunny Fixed (some RPC issue with git clone in the first build; reran and it passed)

@lunny
Copy link
Member

lunny commented Dec 9, 2016

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 9, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 9, 2016

@ethantkoenig Why is this needed?

@ethantkoenig
Copy link
Member Author

@bkcsoft I am planning to add API endpoints for editing/removing an organization's teams, and that will require EditTeamOption. See go-gitea/go-sdk#25

@tboerger
Copy link
Member

tboerger commented Dec 9, 2016

Than you should update the sdk together with that pr

@ethantkoenig
Copy link
Member Author

@tboerger The SDK has already been updated; go-gitea/go-sdk#25 has been merged.

It was my understanding that to make an update to the SDK, one first issues a PR to the SDK repo, and when that is merged, then issue a second PR to gitea that updates vendors/ accordingly. Apologies if this isn't the right workflow.

@tboerger
Copy link
Member

tboerger commented Dec 9, 2016

I was talking about updating vendor together with the api changes :)

@ethantkoenig
Copy link
Member Author

Oh, will do!

@tboerger tboerger removed this from the 1.0.0 milestone Dec 10, 2016
@tboerger tboerger added reviewed/invalid and removed type/enhancement An improvement of existing functionality lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2016
@ethantkoenig ethantkoenig deleted the update_sdk branch December 24, 2016 19:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
@delvh delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed reviewed/invalid labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants