Skip to content

Add oauth providers via cli #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 12, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update text, and change command to add
  • Loading branch information
techknowlogick authored Aug 23, 2018
commit c14da072077a07807a7dca72463198b7643c3e6d
4 changes: 2 additions & 2 deletions cmd/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ var (
}

microcmdAuthOauth = cli.Command{
Name: "oauth",
Name: "add-oauth",
Usage: "Add new Oauth authentication source",
Action: runAddOauth,
Flags: []cli.Flag{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this flag array could be moved out to array so that it could be reused in both add and update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lafriks updated.

Expand Down Expand Up @@ -180,7 +180,7 @@ var (
cli.StringFlag{
Name: "custom-auth-url",
Value: "",
Usage: "Use a custom Authorize URL (option for GitLab/GitHub)",
Usage: "Use a custom Authorization URL (option for GitLab/GitHub)",
},
cli.StringFlag{
Name: "custom-token-url",
Expand Down