Skip to content

Remove feature global code search from GitLab CE #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

codescale
Copy link
Contributor

Just recently we realized that it's not possible to enable Global Search for a GitLab CE.

Their admin docs actually also says so. That's why I think it should be mark like that in your comparison page :)

@codecov-io
Copy link

Codecov Report

Merging #4875 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4875      +/-   ##
==========================================
+ Coverage   37.21%   37.22%   +<.01%     
==========================================
  Files         305      305              
  Lines       45043    45043              
==========================================
+ Hits        16763    16767       +4     
+ Misses      25842    25841       -1     
+ Partials     2438     2435       -3
Impacted Files Coverage Δ
models/repo_list.go 56.37% <0%> (-1.35%) ⬇️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cc3a9...b865866. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2018
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Sep 5, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2018
@techknowlogick techknowlogick merged commit bd1bf2a into go-gitea:master Sep 5, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants