Fixed flattening on circular $ref's with remote URL #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 90.41% 90.38% -0.04%
==========================================
Files 7 6 -1
Lines 1555 1550 -5
==========================================
- Hits 1406 1401 -5
Misses 98 98
Partials 51 51
Continue to review full report at Codecov.
|
* fixes go-openapi#57 (supports URLs as basepath in all conditions) * fixes go-openapi#66 (supports empty BasePath, defaults to current working directory) Flatten no more attempts to set a default BasePath, and rely on go-openapi/spec to set a defaut (cwd). Tests * added Azure network spec and tested flattening, with or without expansion, from both local files and http remote. * beefed up assertions for this fixture, checking that all remaining $ref's actually resolve in the root document * re-enacted Appveyor CI for windows * Updated README Signed-off-by: Frederic BIDON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten no more attempts to set a default BasePath, and rely on go-openapi/spec
to set a defaut (cwd).
Tests
from both local files and http remote.
actually resolve in the root document
Signed-off-by: Frederic BIDON [email protected]