This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Improve makefile to prepare for submission of hombrew recipe #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the cli to match apache bench more closely. Goad now also loads a default configuration if present in goad.ini. Similar changes are applied to the lambdas cli to maintain consistency. Also the tags description in the help output have been adapted to match AB more closely. Careful this breaks the backwards compatibility with follwing features: * the timelimit flag changing from -N to -t * the timeout flag changing from -t to -s * the url flag -u which is now passed as an argument to goad * the awsprofile flag which was broken and hence removed from the cli * the shorthand of the region option -r * the shorthand of the body option -b * the shorthand of the json file output option -o This commit also introdcues follwing changes: * load default configuration from goad.ini * deleted unused: helpers/stringsliceflag.go
The build process now allows for reproducable builds resulting in the same checksums every time the build pipeline is executed. This is achieved by overwriting the timestamps of build targets in zip-files with the timestamp of the latest git commit. The latest commit hash of the git repository is used to provide a reproducable build identifier. To allow the standard go install routine to install goad the goad.go file is moved into a separate package. Allowing for a main.go calling the cli in the project root. These changes facilitate the creation of a recipe for the homebrew package manager. Also we update the base image within the docker file since we are using a newer version of git to format the date in this new build process. The old base image contained an older version of git.
This creates a working draft homebrew recipe. After merging the changed build process this recipe can be adapted to use a tagged version within the offical goad repository and submitted to the homebrew-core repository.
cwaltken-edrans
force-pushed
the
104-create-a-pull-request-for-homebrew
branch
5 times, most recently
from
456bc2c to
0dc6b56
Compare
cwaltken-edrans
force-pushed
the
104-create-a-pull-request-for-homebrew
branch
from
0dc6b56 to
4fef50d
Compare
Collaborator
Author
|
I had to make some small changes to the travis.yml to allow the new build process to use a newer version of git. Now travis also executes cleanly in forks of this repository and runs the unit tests within the project. |
Member
|
awesome, thanks @cwaltken-edrans |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a fully functional hombrew recipe that build upon the changes to the Makefile build process. As soon as this is merged we can submit a PR to the homebrew-core repository.
The build process now allows for reproducable builds resulting in the same checksums every time the build pipeline is executed. This is achieved by overwriting the timestamps of build targets in zip-files with the timestamp of the latest git commit.
The latest commit hash of the git repository is used to provide a reproducable build identifier.
To allow the standard go install routine to install goad the goad.go file is moved into a separate package, allowing for a main.go as entry point calling the cli in the project root.
These changes facilitate the creation of a recipe for the homebrew package manager.
Also we update the base image within the docker file since we are using a newer version of git to format the date in this new build process. The old base image contained an older version of git.