Enforce unique job keys #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting an empty string value then calling Get now
returns empty string and true.
Also remove the need for using a sentinel value ("*")
when doing a reset.
This commit does a couple of things: 1. It adds a new `SetIfNotExists` methods to replicated maps that will set a value only if it isn't already in the map. 2. It ensures the pool node `DispatchJob` method returns an the new `ErrJobExists` error when attempting to queue a job with a key that already exists. It was previously the responsibility of the client to ensure no two calls to DispatchJob used the same key, now the pool package enforces it.
So that we can ensure decoding all the parts in Go. This replaces the previous algo that was using : to separate key and values which was not working if a key or a value also contained :.
Fix all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few of things:
Geton a replicated map for a key that was set with an empty string returns"", trueSetIfNotExistsmethods to replicated maps that will set a value only if it isn't already in the map.DispatchJobmethod returns the newErrJobExistserror when attempting to queue a job with a key that already exists.It was previously the responsibility of the client to ensure no two calls to DispatchJob used the same key, now the pool package enforces it.