providers/proxy: no exposed urls #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #3151 +/- ##
===========================================
- Coverage 92.03% 52.40% -39.63%
===========================================
Files 466 466
Lines 21170 21212 +42
===========================================
- Hits 19482 11114 -8368
- Misses 1688 10098 +8410
Continue to review full report at Codecov.
|
BeryJu
force-pushed
the
providers/proxy/no-exposed-urls
branch
7 times, most recently
from
711608b to
d6b70f1
Compare
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
BeryJu
force-pushed
the
providers/proxy/no-exposed-urls
branch
2 times, most recently
from
3c66f80 to
3a888d5
Compare
Signed-off-by: Jens Langhammer <[email protected]>
BeryJu
force-pushed
the
providers/proxy/no-exposed-urls
branch
from
3a888d5 to
376b597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly simplifies the Forward auth setup for traefik and envoy. It'll remove the requirement
/outpost.goauthentik.ioto be openly accessible, which makes setup easier and decreases attack surface.For traefik/envoy it'll work like:
X-authentik-auth-callbackquery parameter setSadly, nginx still doesn't support getting a 302 from an auth subrequest without writing the 302 redirect in the nginx config, so nginx will require
/outpost.goauthentik.io/startto be publicly accessible (which is still a bit better)Since this only lowers the requirements it shouldn't be a breaking change, but needs more testing with traefik and nginx