Skip to content

Consider other project name, as git-shell means something else #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nanoant opened this issue Dec 15, 2015 · 9 comments
Closed

Consider other project name, as git-shell means something else #1

nanoant opened this issue Dec 15, 2015 · 9 comments

Comments

@nanoant
Copy link
Contributor

nanoant commented Dec 15, 2015

@unknwon as I mentioned on Gitter, IMHO git-shell is unlucky name. While I understand your intention that you wanted use pure git shell command but there are few caveats:

  1. This project is not a shell, it is a library (module, API, wrapper), see definition of Shell
  2. There is already git-shell part of official Git project and it is something else (a real but restricted login shell in fact) see https://git-scm.com/docs/git-shell

Therefore consider renaming the project to something like go-git-module, go-git-wrapper or some other name which reflects what is the purpose of this project. This will help community to properly lookup your project and help with extending it.

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

I think give better README description is good enough for people to clarify what is does.

Thoughts?

@nanoant
Copy link
Contributor Author

nanoant commented Dec 15, 2015

Like I said, this project isn't a shell, it is a go wrapper around git command that isn't an shell command either, it is just a command line program, not shell builtin.
Yet this project may be very useful for some others, given it has right name and right description, this is what GitHub searched first.

Giving explanation in README will clarify that to anyone coming there by mistake, looking for shell, but this won't help much finding go module or go wrapper for git.

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

OK... how about gogs-shell.

@nanoant
Copy link
Contributor Author

nanoant commented Dec 15, 2015

Don't get me wrong, because this project is great, but why you want call shell something that isn't a shell according to common definition https://en.wikipedia.org/wiki/Shell_(computing)?

If you don't like git-wrapper, maybe git-cmd then?

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

I want to call it git-module but based on your argument it is also too vague ..

@nanoant
Copy link
Contributor Author

nanoant commented Dec 15, 2015

Maybe it is vague, but at least it is what the name says :)

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

Cool! So... a lot rename on Gogs main repo..

@nanoant
Copy link
Contributor Author

nanoant commented Dec 15, 2015

Luckily GitHub redirects the old name to the new name well, including git clones. https://help.github.com/articles/renaming-a-repository/

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

But Go import path does not redirect 😂

strk pushed a commit to strk/git-module that referenced this issue Nov 12, 2016
Link to go-gitea/git build status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants