cmd/buildid: crashes trying to write buildid in binary built by Go 1.5

[stevemk14ebr]

What version of Go are you using (go version)?

1.17.2 linux/amd64

$ go version
1.17.2 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

linux

go env Output

$ go env

What did you do?

run go tool buildid -w <filepath> on a go 1.5 binary and the following error will occur:

panic: runtime error: slice bounds out of range [:-1]

goroutine 1 [running]:
main.main()
        /usr/local/go/src/cmd/buildid/buildid.go:56 +0x60d

The line:

go/src/cmd/buildid/buildid.go

Line 56 in cfad1ff

newID := id[:strings.LastIndex(id, "/")] + "/" + buildid.HashToString(hash)

This is because in go 1.5 the contentID did not exist, so the slash seperator is not present, causing issues. The buildid tool doesn't consider legacy buildID/actionID/contentID layouts.

What did you expect to see?

The buildID / contentID to be written

What did you see instead?

crash

[ianlancetaylor]

Also fails with Go 1.6 through Go 1.9. Go 1.10 and later seem to work.

Those older versions of Go are not supported. If someone wants to contribute a fix that would be fine but I don't think we are going to actively work on this.

[gopherbot]

Change https://go.dev/cl/409535 mentions this issue: cmd/buildid: reject rewriting legacy buildids