x/tools/gopls: `go clean` fails with ENOTEMPTY (openbsd) causing gopls test flakes

[gopherbot]

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUnknownRevision/bad/nested/default
goroutine profile: total 9
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe94cb0 0xe9493a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe94caf	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:198
#	0xe94939	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x4c8667	os.(*file).close+0x87							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_unix.go:333
#	0xc2968c	os.(*File).Close+0x2c							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_posix.go:23
#	0xc2932e	golang.org/x/tools/internal/gopathwalk.(*walker).walk+0x74e		/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:337
#	0xc28207	golang.org/x/tools/internal/gopathwalk.walkDir+0x347			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:120
#	0xc3af25	golang.org/x/tools/internal/gopathwalk.WalkSkip+0x305			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:77
#	0xc3ae12	golang.org/x/tools/internal/imports.(*ModuleResolver).scan.func4+0x1f2	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/imports/mod.go:643

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod/cache/download/example.com/@v: directory not empty
--- FAIL: TestUnknownRevision/bad/nested/default (34.95s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestUnknownRevision/bad/nested/default"

2024-06-20 14:20 x_tools-gotip-openbsd-amd64 tools@99779e9a go@4f77a835 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)

=== RUN   TestUnknownRevision/bad/nested/default
goroutine profile: total 9
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe94cb0 0xe9493a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe94caf	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:198
#	0xe94939	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x4c8667	os.(*file).close+0x87							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_unix.go:333
#	0xc2968c	os.(*File).Close+0x2c							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_posix.go:23
#	0xc2932e	golang.org/x/tools/internal/gopathwalk.(*walker).walk+0x74e		/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:337
#	0xc28207	golang.org/x/tools/internal/gopathwalk.walkDir+0x347			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:120
#	0xc3af25	golang.org/x/tools/internal/gopathwalk.WalkSkip+0x305			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:77
#	0xc3ae12	golang.org/x/tools/internal/imports.(*ModuleResolver).scan.func4+0x1f2	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/imports/mod.go:643

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod/cache/download/example.com/@v: directory not empty
--- FAIL: TestUnknownRevision/bad/nested/default (34.95s)

— watchflakes

[gabyhelp]

Similar Issues

• x/tools/gopls/internal/test/integration/modfile: TestUnknownRevision/good/nested/default failures #67982
• x/tools/gopls/internal/test/integration/completion: TestUndownloadedModule failures #64981
• x/tools/gopls: mod cache refresh timers run after view shutdown #67865
• x/tools/gopls/internal/test/integration/misc: TestRenamePackage_NestedModule failures #64984
• x/tools/gopls/internal/test/integration/workspace: TestReferences failures #64795
• x/tools/gopls/internal/test/integration/completion: TestCompleteAllFields failures #64787
• x/tools/gopls/internal/test/integration/template: TestModFileModification failures #66104
• x/tools/gopls/internal/test: shutdown failures with "directory not empty" #64971
• x/tools/gopls/internal/test/integration/misc: TestThirdPartyPackageHighlight_Issue43511 failures #64983
• x/tools/gopls/internal/test/integration/misc: TestThirdPartyPackageHighlight_Issue43511 failures #64967

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg ~ "golang.org/x/tools/gopls/internal/test/.*" && goos == "openbsd" && `cleaning sandbox: cleaning modcache`

And the problems were:

script:2.18: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

— watchflakes

[findleyr]

@matloob @samthanawalla @adonovan

Any particular reason why only on openbsd we'd be seeing these cleanup failures? Was there any recent change to the go command on openbsd? I don't think much has changed in gopls with respect to the integration test cleanup.

Not a super high priority, but curious.